enhanced unittests, added pod for addrecord and newrecord, using ->new() everywhere, new parameter "create"

This commit is contained in:
git@daemon.de
2015-02-16 11:41:35 +01:00
parent f8308c72c4
commit 1672943fcc
7 changed files with 208 additions and 156 deletions

View File

@@ -13,7 +13,7 @@ use Exporter ();
use vars qw(@ISA @EXPORT);
use utf8;
$Crypt::PWSafe3::Field::VERSION = '1.05';
$Crypt::PWSafe3::Field::VERSION = '1.06';
%Crypt::PWSafe3::Field::map2type = (
uuid => 0x01,
@@ -120,9 +120,6 @@ sub new {
$self->{name} = $self->{type};
}
#print "New Field of type $self->{name}\n";
#print "Field Value: $self->{value}\n";
return $self;
}
@@ -151,7 +148,7 @@ raw implementation and you normally don't have to cope with it.
However, if you ever do, you can do it this way:
my $field = new Crypt::PWSafe3::Field(
my $field = Crypt::PWSafe3::Field->new(
value => 'testing',
name => 'title
);

View File

@@ -13,7 +13,7 @@ use Exporter ();
use vars qw(@ISA @EXPORT);
use utf8;
$Crypt::PWSafe3::HeaderField::VERSION = '1.04';
$Crypt::PWSafe3::HeaderField::VERSION = '1.05';
%Crypt::PWSafe3::HeaderField::map2name = (
0x00 => "version",
@@ -135,7 +135,7 @@ Crypt::PWSafe3::HeaderField - represent a passwordsafe v3 header field.
my $who = $vault->getheader('wholastsaved');
print $who->value;
my $h = new Crypt::PWSafe3::HeaderField(name => 'savedonhost',
my $h = Crypt::PWSafe3::HeaderField->new(name => 'savedonhost',
value => 'localhost');
$vault->addheader($h);
@@ -147,7 +147,7 @@ raw implementation and you normally don't have to cope with it.
However, if you ever do, you can add/replace any field type
this way:
my $field = new Crypt::PWSafe3::HeaderField(
my $field = Crypt::PWSafe3::HeaderField->new(
value => 'localhost',
name => 'savedonhost'
);

View File

@@ -15,7 +15,7 @@ my %map2type = %Crypt::PWSafe3::Field::map2type;
my %map2name = %Crypt::PWSafe3::Field::map2name;
$Crypt::PWSafe3::Record::VERSION = '1.08';
$Crypt::PWSafe3::Record::VERSION = '1.09';
foreach my $field (keys %map2type ) {
eval qq(
@@ -46,50 +46,50 @@ sub new {
my $time = time;
$self->addfield(new Crypt::PWSafe3::Field(
name => 'uuid',
raw => $newuuid,
$self->addfield(Crypt::PWSafe3::Field->new(
name => 'uuid',
raw => $newuuid,
));
$self->addfield(Crypt::PWSafe3::Field->new(
name => 'ctime',
value => $time,
));
$self->addfield(Crypt::PWSafe3::Field->new(
name => 'mtime',
value => $time
));
$self->addfield(Crypt::PWSafe3::Field->new(
name => 'lastmod',
value => $time
));
$self->addfield(Crypt::PWSafe3::Field->new(
name => 'passwd',
value => ''
));
$self->addfield(Crypt::PWSafe3::Field->new(
name => 'user',
value => ''
));
$self->addfield(new Crypt::PWSafe3::Field(
name => 'ctime',
value => $time,
$self->addfield(Crypt::PWSafe3::Field->new(
name => 'title',
value => ''
));
$self->addfield(new Crypt::PWSafe3::Field(
name => 'mtime',
value => $time
));
$self->addfield(new Crypt::PWSafe3::Field(
name => 'lastmod',
value => $time
));
$self->addfield(Crypt::PWSafe3::Field->new(
name => 'notes',
value => ''
));
$self->addfield(new Crypt::PWSafe3::Field(
name => 'passwd',
value => ''
));
$self->addfield(new Crypt::PWSafe3::Field(
name => 'user',
value => ''
));
$self->addfield(new Crypt::PWSafe3::Field(
name => 'title',
value => ''
));
$self->addfield(new Crypt::PWSafe3::Field(
name => 'notes',
value => ''
));
$self->addfield(new Crypt::PWSafe3::Field(
name => 'group',
value => ''
));
$self->addfield(Crypt::PWSafe3::Field->new(
name => 'group',
value => ''
));
return $self;
}
@@ -100,7 +100,7 @@ sub modifyfield {
my($this, $name, $value) = @_;
if (exists $map2type{$name}) {
my $type = $map2type{$name};
my $field = new Crypt::PWSafe3::Field(
my $field = Crypt::PWSafe3::Field->new(
type => $type,
value => $value
);
@@ -114,15 +114,15 @@ sub modifyfield {
$this->addfield($field);
# mark the field as modified if it's passwd field
$this->addfield(new Crypt::PWSafe3::Field(
name => 'mtime',
value => $time
)) if $name eq 'passwd';
$this->addfield(Crypt::PWSafe3::Field->new(
name => 'mtime',
value => $time
)) if $name eq 'passwd';
$this->addfield(new Crypt::PWSafe3::Field(
name => "lastmod",
value => $time
));
$this->addfield(Crypt::PWSafe3::Field->new(
name => "lastmod",
value => $time
));
return $field;
}
else {
@@ -134,7 +134,7 @@ sub genuuid {
#
# generate a v4 uuid string
my($this) = @_;
my $ug = new Data::UUID;
my $ug = Data::UUID->new();
my $uuid = $ug->create();
return $uuid;
}

View File

@@ -8,7 +8,7 @@
package Crypt::PWSafe3::SHA256;
$Crypt::PWSafe3::SHA256::VERSION = '1.02';
$Crypt::PWSafe3::SHA256::VERSION = '1.03';
use Digest::SHA;
@@ -17,7 +17,7 @@ sub new {
my $class = ref($this) || $this;
my $self = { };
bless($self, $class);
my $sha = new Digest::SHA('SHA-256');
my $sha = Digest::SHA->new('SHA-256');
return $sha;
}