move to codeberg and fix memory leaks (#1)

.gitignore

@@ -0,0 +1,2 @@
+*.o
+dicepwgen

.woodpecker/build.yaml

@@ -0,0 +1,29 @@
+matrix:
+  platform:
+    - linux/amd64
+
+labels:
+  platform: ${platform}
+    
+steps:
+  build-n-test:
+    when:
+      event: [push]
+    image: alpine:latest
+    commands:
+      - apk update
+      - apk add --no-cache bash build-base words-en gdb valgrind
+      # build
+      - make
+      # look for memory leaks etc
+      - valgrind --leak-check=full --show-reachable=yes ./dicepwgen 2>&1 | tee log | grep "All heap blocks were freed"
+      - cat log
+      # enable in case of a crash
+      #- gdb -batch -ex "run" -ex "bt" --args dicepwgen
+      # check if we really get a password
+      - ./dicepwgen -y | grep -E '[a-z]*%'
+      # check a custom dict file and if we get 6 words when requested
+      - test 6 -eq $(./dicepwgen -f contrib/american-english-insane -c 6 | tee log | sed 's/[a-zA-Z]//g' | wc -c)
+      - cat log
+
+

README.md

@@ -1,6 +1,14 @@
+[![status-badge](https://ci.codeberg.org/api/badges/15537/status.svg)](https://ci.codeberg.org/repos/15537)
+[![License](https://img.shields.io/badge/license-GPL-blue.svg)](https://codeberg.org/scip/diceware/raw/branch/master/LICENSE)
+[![Documentation](https://img.shields.io/badge/manpage-documentation-blue)](https://codeberg.org/scip/diceware/raw/branch/main/dicepwgen.pod)
+
 ## dicepwgen - A diceware password generator
 
-This is the README file for the password generator dicepwgen.
+`dicepwgen` generates a [diceware password](https://de.wikipedia.org/wiki/Diceware)
+using a dictionary file. By default it uses pseudo random dice tosses,
+but it is also possible to use real dices and enter the numbers by using
+the option `-t`, which is the most secure way to generate diceware passwords.
+
 
 ## Documentation
 

dicepwgen.c

@@ -37,14 +37,12 @@ int usage() {
           "-y --symbols              Replace space with -, add non-letters\n"
           "-d --debug                Enable debug output\n"
           "-v --version              Print program version\n"
-          "-h -? --help              Print this help screen\n"
+          "-h -? --help              Print this help screen\n");
-          );
   return 1;
 }
 
 int WMIN, WMAX, humantoss, verbose, dontjump, symbols;
 
-
 int main(int argc, char **argv) {
   int count = 4;
   char *dictfile = NULL;
@@ -67,7 +65,8 @@ int main (int argc, char **argv)  {
       {"debug", no_argument, NULL, 'd'},
   };
 
-   while ((opt = getopt_long(argc, argv, "l:m:tf:c:vh?dny", longopts, NULL)) != -1) {
+  while ((opt = getopt_long(argc, argv, "l:m:tf:c:vh?dny", longopts, NULL)) !=
+         -1) {
     switch (opt) {
     case 'v':
       fprintf(stderr, "This is %s version %s\n", argv[0], VERSION);
@@ -176,7 +175,7 @@ void getwords(char *dictfile, int count) {
 
   free(tossed);
 
-  for(i=0; i<6666; i++)
+  for (i = 0; i < 66667; i++)
     if (words[i] != NULL)
       free(words[i]);
 

dicepwgen.h

@@ -22,23 +22,24 @@
 #ifndef HAVE_DICE_H
 #define HAVE_DICE_H
 
-#include <stdio.h>
-#include <unistd.h>
-#include <getopt.h>
-#include <stdlib.h>
-#include <stdint.h>
-#include <string.h>
 #include <ctype.h>
+#include <getopt.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
 
+#include "debug.h"
 #include "dictfile.h"
 #include "tossing.h"
-#include "debug.h"
 
 #define STRINGIZE(x) #x
 #define STRINGIZE_VALUE_OF(x) STRINGIZE(x)
 
-#define  VERSION  "1.2.0"
+// #define VERSION "1.3.0"
 #define RLEN 1024
+static const char VERSION[] = "1.3.0";
 
 extern int humantoss;
 extern int verbose;

dictfile.c

@@ -35,24 +35,20 @@ int *incr_dicedigit(int *digits) {
         digits[2] = 100;
         if (digits[1] == 6000) {
           digits[1] = 1000;
-	  digits[0] += 10000; /* may overflow to 71111, must be catched by caller */
+          digits[0] +=
-	}
+              10000; /* may overflow to 71111, must be catched by caller */
-	else
+        } else
           digits[1] += 1000;
-      }
+      } else
-      else
         digits[2] += 100;
-    }
+    } else
-    else
       digits[3] += 10;
-  }
+  } else
-  else
     digits[4]++;
 
   return digits;
 }
 
-
 int get_dicenum(int *digits) {
   /*
     get the actual number of an array of dice digits
@@ -87,7 +83,7 @@ char **fetch_dict(char *dictfile) {
     exit(1);
   }
 
-  words = malloc(66666 * sizeof(char *));
+  words = malloc(66667 * sizeof(char *));
   digits = malloc(5 * sizeof(int));
   jump = rand_lim(32);
 
@@ -100,18 +96,16 @@ char **fetch_dict(char *dictfile) {
   pos = 11111;
   next = 0;
 
-  for(i=0; i<6666; i++)
+  for (i = 0; i < 66667; i++)
     words[i] = NULL;
 
-  
 LOOP:
   while ((linelen = getline(&line, &len, DICT)) != -1) {
     if (!dontjump) {
       if (jump > 0) {
         jump--;
         continue;
-      }
+      } else {
-      else {
         jump = rand_lim(32);
       }
     }
@@ -138,7 +132,8 @@ char **fetch_dict(char *dictfile) {
       digits = incr_dicedigit(digits);
       pos = get_dicenum(digits);
 
-      /* this is what pos gets next after 66666, which is max reachable with 5 dices */
+      /* this is what pos gets next after 66666, which is max reachable with 5
+       * dices */
       if (pos == 71111)
         break;
     } /* endif word 4<=>10 */