always show actions

Makefile

@@ -67,10 +67,10 @@ test: clean buildlocal
 
 testlint: test lint
 
-lint-basic:
+lint:
 	golangci-lint run --enable-only errcheck,govet,ineffassign,staticcheck,unused
 
-lint:
+lint-full:
 	golangci-lint run --show-stats=false
 
 testfuzzy: clean

README.md

@@ -538,7 +538,6 @@ index                       - manage indicies
   close                     - close an index
   fields                    - show info about field capabilities
   ilm                       - show ilm status
-  du                        - show index disk usage
   alias                     - manage index aliases
     create                  - create an index alias
     list                    - list index aliases
@@ -556,7 +555,6 @@ node                        - manage nodes
   list                      - list nodes
   show                      - show details about a node
   clients                   - show node http clients
-  usage                     - show node usage stats
 role                        - manage roles
   list                      - list roles
   show                      - show details about a role

cmd/api.go

@@ -72,7 +72,7 @@ func ApiShow(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Capi)
+			complete(cmd, Capi)
 		},
 	}
 }
@@ -91,12 +91,6 @@ func ApiRepl(conf *cfg.Config) *cli.Command {
 				Aliases:     []string{"p"},
 				Sources:     cli.EnvVars("PAGER", "ES_JSON_PAGER"),
 			},
-			&cli.BoolFlag{
-				Name:        "human-readable-cat",
-				Usage:       "enable human readable /_cat output",
-				Destination: &conf.HumanCat,
-				Aliases:     []string{"H"},
-			},
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {

cmd/ccr.go

@@ -59,7 +59,7 @@ func CcrStatus(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Ccluster)
+			complete(cmd, Ccluster)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -115,7 +115,7 @@ func CcrRemoteInfo(conf *cfg.Config) *cli.Command {
 		UsageText: "info [options] [<index>]",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {

cmd/ccr_follower.go

@@ -60,7 +60,7 @@ func CcrFollowerRenew(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -82,7 +82,7 @@ func CcrFollowerResume(conf *cfg.Config) *cli.Command {
 		UsageText: "resume [options] <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -104,7 +104,7 @@ func CcrFollowerPause(conf *cfg.Config) *cli.Command {
 		UsageText: "pause [options] <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -126,7 +126,7 @@ func CcrFollowerUnfollow(conf *cfg.Config) *cli.Command {
 		UsageText: "unfollow [options] <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -158,7 +158,7 @@ func CcrFollowerAdd(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -181,7 +181,7 @@ func CcrFollowerDelete(conf *cfg.Config) *cli.Command {
 		UsageText: "delete <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -205,7 +205,7 @@ func CcrFollowerShow(conf *cfg.Config) *cli.Command {
 		UsageText: "show <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {

cmd/cluster.go

@@ -83,7 +83,7 @@ func ClusterSwitch(conf *cfg.Config) *cli.Command {
 		Aliases:   []string{"ctx"},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Ccluster)
+			complete(cmd, Ccluster)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {

cmd/cluster_reroute.go

@@ -50,7 +50,7 @@ func ClusterRerouteMove(conf *cfg.Config) *cli.Command {
 		UsageText: "move [options] <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Flags: []cli.Flag{
@@ -95,7 +95,7 @@ func ClusterRerouteAllocateReplica(conf *cfg.Config) *cli.Command {
 		UsageText: "allocate-replica [options] <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Flags: []cli.Flag{
@@ -133,7 +133,7 @@ func ClusterRerouteCancel(conf *cfg.Config) *cli.Command {
 		UsageText: "cancel [options] <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Flags: []cli.Flag{
@@ -185,7 +185,7 @@ func ClusterRerouteAllocatePrimary(conf *cfg.Config, stale bool) *cli.Command {
 		UsageText: name + " [options] <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Flags: []cli.Flag{

cmd/cluster_settings.go

@@ -105,7 +105,7 @@ func ClusterSettingsSet(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cclustersettings)
+			complete(cmd, Cclustersettings)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {

cmd/completion.go

@@ -36,11 +36,18 @@ const (
 	Cclustersettings
 )
 
-func complete(conf *cfg.Config, cmd *cli.Command, what int) {
+func complete(cmd *cli.Command, what int) {
 	if cmd.NArg() > 0 {
 		return
 	}
 
+	// FIXME: config should load from root.Before(), see https://github.com/urfave/cli/issues/2348
+	// workaround: load it directly here
+	conf := cfg.NewConfig()
+	if err := conf.Init(); err != nil {
+		return
+	}
+
 	var (
 		list []string
 		err  error

cmd/datastream.go

@@ -91,7 +91,7 @@ func DatastreamShow(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cdatastream)
+			complete(cmd, Cdatastream)
 		},
 	}
 }
@@ -113,7 +113,7 @@ func DatastreamCreate(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cdatastream)
+			complete(cmd, Cdatastream)
 		},
 	}
 }
@@ -135,7 +135,7 @@ func DatastreamDelete(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cdatastream)
+			complete(cmd, Cdatastream)
 		},
 	}
 }
@@ -148,7 +148,7 @@ func DatastreamRollover(conf *cfg.Config) *cli.Command {
 		UsageText: "rollover <data stream>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Flags: []cli.Flag{
@@ -205,7 +205,7 @@ func DatastreamIlm(conf *cfg.Config) *cli.Command {
 		UsageText: "ds ilm <name>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cdatastream)
+			complete(cmd, Cdatastream)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {

cmd/ilm.go

@@ -123,7 +123,7 @@ func IlmShow(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cilm)
+			complete(cmd, Cilm)
 		},
 	}
 }

cmd/index.go

@@ -41,7 +41,6 @@ func Index(conf *cfg.Config) *cli.Command {
 			IndexClose(conf),
 			IndexFields(conf),
 			IndexIlm(conf),
-			IndexDu(conf),
 
 			// sub commands
 			IndexAlias(conf),
@@ -111,7 +110,7 @@ func IndexShow(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 	}
 }
@@ -181,7 +180,7 @@ func IndexDelete(conf *cfg.Config) *cli.Command {
 		UsageText: "delete <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -202,7 +201,7 @@ func IndexClose(conf *cfg.Config) *cli.Command {
 		UsageText: "close <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -244,7 +243,7 @@ func IndexFields(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -265,7 +264,7 @@ func IndexIlm(conf *cfg.Config) *cli.Command {
 		UsageText: "index ilm <index>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -278,24 +277,3 @@ func IndexIlm(conf *cfg.Config) *cli.Command {
 		},
 	}
 }
-
-func IndexDu(conf *cfg.Config) *cli.Command {
-	return &cli.Command{
-		Name:      "du",
-		Usage:     "show index disk usage",
-		UsageText: "index du <index>",
-
-		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
-		},
-
-		Action: func(ctx context.Context, cmd *cli.Command) error {
-			index := cmd.Args().Get(0)
-			if index == "" {
-				return errors.New("no index specified")
-			}
-
-			return es.IndexDiskusage(conf, index)
-		},
-	}
-}

cmd/index_alias.go

@@ -52,7 +52,7 @@ func IndexAliasCreate(conf *cfg.Config) *cli.Command {
 		UsageText: "create <index> <alias>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -76,7 +76,7 @@ func IndexAliasDelete(conf *cfg.Config) *cli.Command {
 		UsageText: "delete <index> <alias>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -100,7 +100,7 @@ func IndexAliasRollover(conf *cfg.Config) *cli.Command {
 		UsageText: "rollover <alias>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 
 		Flags: []cli.Flag{

cmd/index_template.go

@@ -71,7 +71,7 @@ func IndexTemplateShow(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 	}
 }
@@ -215,7 +215,7 @@ func IndexTemplateDelete(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cindex)
+			complete(cmd, Cindex)
 		},
 	}
 }

cmd/node.go

@@ -36,7 +36,6 @@ func Node(conf *cfg.Config) *cli.Command {
 			NodeList(conf),
 			NodeShow(conf),
 			NodeClients(conf),
-			NodeUsage(conf),
 		},
 	}
 }
@@ -61,7 +60,7 @@ func NodeShow(conf *cfg.Config) *cli.Command {
 		UsageText: "show [options] <node>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cnode)
+			complete(cmd, Cnode)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -91,7 +90,7 @@ func NodeClients(conf *cfg.Config) *cli.Command {
 		},
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cnode)
+			complete(cmd, Cnode)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {
@@ -104,19 +103,3 @@ func NodeClients(conf *cfg.Config) *cli.Command {
 		},
 	}
 }
-
-func NodeUsage(conf *cfg.Config) *cli.Command {
-	return &cli.Command{
-		Name:      "usage",
-		Usage:     "show node usage stats",
-		UsageText: "usage [options] [<node>]",
-
-		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Cnode)
-		},
-
-		Action: func(ctx context.Context, cmd *cli.Command) error {
-			return es.NodeUsage(conf, cmd.Args().Get(0))
-		},
-	}
-}

cmd/roles.go

@@ -68,7 +68,7 @@ func RoleShow(conf *cfg.Config) *cli.Command {
 		UsageText: "show [options] <role>",
 
 		ShellComplete: func(ctx context.Context, cmd *cli.Command) {
-			complete(conf, cmd, Crole)
+			complete(cmd, Crole)
 		},
 
 		Action: func(ctx context.Context, cmd *cli.Command) error {

pkg/cfg/config.go

@@ -102,7 +102,6 @@ type Config struct {
 	DryRun                              bool // rollover: -n
 
 	Tag string // api ls: -t
-	HumanCat bool   // api repl: -H
 
 	Ilm Ilm // ilm create
 

pkg/es/api.go

@@ -45,25 +45,22 @@ import (
 )
 
 const (
-	intro = `# Input format: verb path [data]"
-# 
-# Example:
-# 
-# post /yourindex/_ccr/pause_follow
-# put /yourindex/_settings {"number_of_replicas": 1}
-# 
-# You can also put multiline JSON after the path like:
-# 
-# put /yourindex/_settings
-# {
-#   "number_of_replicas": 1
-# }
-# 
-# If you do NOT  supply a JSON in the first line, you  need to hit ENTER
-# twice to complete.
-#
-# Supply the flag --human-readable-cat, -H to view /_cat API calls in
-# human readable form.`
+	intro = `Input format: verb path [data]"
+
+Example:
+
+post /yourindex/_ccr/pause_follow
+put /yourindex/_settings {"number_of_replicas": 1}
+
+You can also put multiline JSON after the path like:
+
+put /yourindex/_settings
+{
+  "number_of_replicas": 1
+}
+
+If you do NOT  supply a JSON in the first line, you  need to hit ENTER
+twice to complete.`
 )
 
 // holds an API operation via go-openapi/spec
@@ -146,12 +143,8 @@ func ApiRepl(conf *cfg.Config) error {
 			fmt.Printf("failed to call API: %s\n", esErrorString(err))
 		}
 
-		if conf.HumanCat && strings.HasPrefix(parts[1], "/_cat") {
-			fmt.Println(string(raw))
-		} else {
 		pageJsonOutput(conf, raw)
 	}
-	}
 
 	//nolint:nilerr
 	return nil
@@ -223,10 +216,8 @@ func CallAPI(conf *cfg.Config, verb, path, data string) ([]byte, error) {
 		return nil, err
 	}
 
-	if !conf.HumanCat || (conf.HumanCat && !strings.HasPrefix(path, "/_cat")) {
 	req.Header.Add("Content-Type", "application/json")
 	req.Header.Add("Accept", "application/json")
-	}
 
 	// make sure we have got all we need
 	if err := conf.DefaultCluster.CheckAuth(); err != nil {
@@ -280,8 +271,7 @@ func prettyfiJson(conf *cfg.Config, raw []byte) (string, error) {
 
 	err := json.Indent(&pretty, raw, "", "\t")
 	if err != nil {
-		//nolint:nilerr
-		return string(raw), nil
+		return "", fmt.Errorf("json parse error: %w", err)
 	}
 
 	return pretty.String(), nil

pkg/es/index.go

@@ -18,8 +18,6 @@ package es
 
 import (
 	"context"
-	"encoding/json"
-	"errors"
 	"fmt"
 	"log/slog"
 	"regexp"
@@ -30,7 +28,6 @@ import (
 
 	"codeberg.org/scip/esctl/pkg/cfg"
 	"codeberg.org/scip/esctl/pkg/printer"
-	"github.com/charmbracelet/lipgloss"
 	"github.com/elastic/go-elasticsearch/v9/typedapi/cat/indices"
 	"github.com/elastic/go-elasticsearch/v9/typedapi/esdsl"
 	"github.com/elastic/go-elasticsearch/v9/typedapi/types/enums/healthstatus"
@@ -309,79 +306,3 @@ func IndexFields(conf *cfg.Config, index string) error {
 
 	return nil
 }
-
-type Diskusage struct {
-	Total       int64 `json:"total_in_bytes"`
-	Points      int64 `json:"points_in_bytes"`
-	Norms       int64 `json:"norms_in_bytes"`
-	TermVectors int64 `json:"term_vectors_in_bytes"`
-	KnnVectors  int64 `json:"knn_vectors_in_bytes"`
-	BloomFilter int64 `json:"bloom_filter_in_bytes"`
-}
-
-type IndexDiskUsage struct {
-	AllFields Diskusage            `json:"all_fields"`
-	Fields    map[string]Diskusage `json:"fields"`
-}
-
-type ResIndexDiskUsage map[string]IndexDiskUsage
-
-func IndexDiskusage(conf *cfg.Config, index string) error {
-	var bold = lipgloss.NewStyle().Bold(true)
-
-	res, err := conf.DefaultCluster.ES().Indices.DiskUsage(index).
-		RunExpensiveTasks(true).
-		Do(context.Background())
-	if err != nil {
-		return fmt.Errorf("failed to retrieve index disk usage: %w", esErrorString(err))
-	}
-
-	duRes := ResIndexDiskUsage{}
-	if err := json.Unmarshal(res, &duRes); err != nil {
-		return fmt.Errorf("failed to unmarshal disk usage response: %w", err)
-	}
-
-	diskusage, exists := duRes[index]
-	if !exists {
-		return errors.New("no disk usage reported for index")
-	}
-
-	table := printer.NewTableEmpty(conf).
-		WithHeaders("field", "bloom filter", "norms", "points", "term vectors", "knn vectors", "total")
-
-	for name, field := range diskusage.Fields {
-		if strings.HasPrefix(name, "_") || strings.HasSuffix(name, ".keyword") {
-			continue
-		}
-
-		table.AddRow(
-			name,
-			printer.Bytes(field.BloomFilter),
-			printer.Bytes(field.Norms),
-			printer.Bytes(field.Points),
-			printer.Bytes(field.TermVectors),
-			printer.Bytes(field.KnnVectors),
-			printer.Bytes(field.Total),
-		)
-	}
-
-	all := diskusage.AllFields
-
-	table.Sort()
-
-	table.AddRowLate(
-		bold.Render("Summary"),
-		printer.Bytes(all.BloomFilter),
-		printer.Bytes(all.Norms),
-		printer.Bytes(all.Points),
-		printer.Bytes(all.TermVectors),
-		printer.Bytes(all.KnnVectors),
-		printer.Bytes(all.Total),
-	)
-
-	if err := table.Print(); err != nil {
-		return err
-	}
-
-	return nil
-}

pkg/es/node.go

@@ -26,6 +26,7 @@ import (
 
 	"codeberg.org/scip/esctl/pkg/cfg"
 	"codeberg.org/scip/esctl/pkg/printer"
+	"github.com/dustin/go-humanize"
 )
 
 func NodeList(conf *cfg.Config) error {
@@ -37,11 +38,11 @@ func NodeList(conf *cfg.Config) error {
 
 	slog.Debug("ES result", "nodes", nodes)
 
-	table := printer.NewTableEmpty(conf).WithHeaders(
-		"name", "ip", "load1m", "load5m", "load15m", "ram %", "heap %")
+	table := printer.NewTable(conf, 7, len(nodes))
+	table.Addheaders("name", "ip", "load1m", "load5m", "load15m", "ram %", "heap %")
 
-	for _, node := range nodes {
-		table.AddRow(
+	for idx, node := range nodes {
+		table.Entries[idx] = []any{
 			*node.Name,
 			*node.Ip,
 			*node.Load1M,
@@ -49,7 +50,7 @@ func NodeList(conf *cfg.Config) error {
 			*node.Load15M,
 			node.RamPercent,
 			node.HeapPercent,
-		)
+		}
 	}
 
 	table.Sort()
@@ -113,27 +114,18 @@ func NodeShow(conf *cfg.Config, nodename string) error {
 		}
 
 		k8snode := info.Attributes["k8s_node_name"]
-		rank := "none"
-
-		adsel, exists := stat.AdaptiveSelection[id]
-		if exists {
-			rank = *adsel.Rank
-		}
 
 		table.Entries = [][]any{
 			{"Id", id},
 			{"Name", nodename},
 			{"Kubernetes node", k8snode},
 			{"Ip address", info.Ip},
-			{"Node rank", rank},
+			{"Node rank", *stat.AdaptiveSelection[id].Rank},
 			{"JVM", info.Jvm.VmName + " " + info.Jvm.Version},
 			{"JVM Started", time.UnixMilli(info.Jvm.StartTimeInMillis)},
 			{"OS", info.Os.PrettyName + " " + info.Os.Version},
 			{"Node roles", roles},
 			{"Node version", info.Version},
-			// FIXME: not implemented upstream
-			// see: https://github.com/elastic/go-elasticsearch/issues/1526
-			// {"Allocated shards", stat.Allocations.XXX},
 			{"HTTP clients", *stat.Http.CurrentOpen},
 			{"CPUs", *info.Os.AllocatedProcessors},
 			{"Load 15m/5m/1m", fmt.Sprintf("%.2f/%.2f/%.2f",
@@ -142,41 +134,18 @@ func NodeShow(conf *cfg.Config, nodename string) error {
 				stat.Os.Cpu.LoadAverage["1m"],
 			)},
 			{"Open FD's", *stat.Process.OpenFileDescriptors},
-			{"HTTP sesssions current/total", fmt.Sprintf("%d/%d",
-				*stat.Http.CurrentOpen,
-				*stat.Http.TotalOpened,
-			)},
-			{"Traffic rx/tx",
-				printer.ByteString(*stat.Transport.RxSizeInBytes) + " / " + printer.ByteString(*stat.Transport.TxSizeInBytes)},
-			{"Response time avg", time.Duration(*stat.AdaptiveSelection[id].AvgResponseTimeNs)},
+			{"Response time avg", fmt.Sprintf("%dns", *stat.AdaptiveSelection[id].AvgResponseTimeNs)},
 			{"Memory usage (used/avail)",
-				printer.ByteString(*stat.Os.Mem.UsedInBytes) + " / " + printer.ByteString(*stat.Os.Mem.TotalInBytes)},
-			{"Search queries current/total", fmt.Sprintf("%d/%d",
-				stat.Indices.Search.QueryCurrent,
-				stat.Indices.Search.QueryTotal,
-			)},
-			{"Search efficiency", stat.Indices.Search.QueryTimeInMillis / stat.Indices.Search.QueryTotal},
-			{"Docs count", stat.Indices.Docs.Count},
-			{"Merges current/total", fmt.Sprintf("%d/%d",
-				stat.Indices.Merges.Current,
-				stat.Indices.Merges.Total,
-			)},
-			{"Merge docs count current/total", fmt.Sprintf("%d/%d",
-				stat.Indices.Merges.CurrentDocs,
-				stat.Indices.Merges.TotalDocs,
-			)},
-			{"Merge size current/total", fmt.Sprintf("%s/%s",
-				printer.ByteString(stat.Indices.Merges.CurrentSizeInBytes),
-				printer.ByteString(stat.Indices.Merges.TotalSizeInBytes),
-			)},
-			{"CircuitBreaker trip count", *stat.Breakers["fielddata"].Tripped},
+				humanize.Bytes(uint64(*stat.Os.Mem.UsedInBytes)) + " / " + humanize.Bytes(uint64(*stat.Os.Mem.TotalInBytes))},
 		}
 
 		if len(stat.Fs.Data) > 0 {
 			fs := stat.Fs.Data[0]
-			table.AddRow("Storage usage (used/avail)",
-				printer.ByteString(*fs.AvailableInBytes)+" / "+printer.ByteString(*fs.TotalInBytes))
-			table.AddRow("Storage mount", *fs.Mount)
+			table.Entries = append(table.Entries, [][]any{
+				{"Storage usage (used/avail)",
+					humanize.Bytes(uint64(*fs.AvailableInBytes)) + " / " + humanize.Bytes(uint64(*fs.TotalInBytes))},
+				{"Storage mount", *fs.Mount},
+			}...)
 		}
 
 		if err := table.Print(); err != nil {
@@ -235,72 +204,3 @@ func NodeClients(conf *cfg.Config, nodename string) error {
 
 	return table.Print()
 }
-
-func NodeUsage(conf *cfg.Config, nodeid string) error {
-	usage := conf.DefaultCluster.ES().Nodes.Usage()
-
-	if nodeid != "" {
-		usage.NodeId(nodeid)
-	}
-
-	stats, err := usage.Do(context.Background())
-	if err != nil {
-		return fmt.Errorf("failed to get node usage: %w", esErrorString(err))
-	}
-
-	slog.Debug("ES result", "usage", stats)
-
-	table := printer.NewTableEmpty(conf).WithHeaders(
-		"node",
-		"bulk",
-		"doc get",
-		"doc mget",
-		"doc update",
-		"index doc",
-		"index stats",
-		"search",
-		"msearch",
-		"open pit",
-	)
-
-	for id, actions := range stats.Nodes {
-		node, err := getNodeName(conf, id)
-		if err != nil {
-			return err
-		}
-
-		stat := actions.RestActions
-
-		table.AddRow(
-			node,
-			stat["bulk_action"],
-			stat["document_get_action"],
-			stat["document_mget_action"],
-			stat["document_update_action"],
-			stat["document_index_action"],
-			stat["indices_stats_action"],
-			stat["search_action"],
-			stat["msearch_action"],
-			stat["open_point_in_time"],
-		)
-	}
-
-	return table.Print()
-}
-
-func getNodeName(conf *cfg.Config, id string) (string, error) {
-	res, err := conf.DefaultCluster.ES().Nodes.Info().
-		Metric("os").
-		Do(context.Background())
-	if err != nil {
-		return "", fmt.Errorf("failed to get node info: %w", esErrorString(err))
-	}
-
-	for nodeid, node := range res.Nodes {
-		if id == nodeid {
-			return node.Name, nil
-		}
-	}
-
-	return "", nil
-}

pkg/es/shard.go

@@ -163,35 +163,28 @@ func ShardAllocation(conf *cfg.Config, index string) error {
 
 	slog.Debug("ES result", "explain", res)
 
+	currentNode := res.CurrentNode
+
 	table := printer.NewTable(conf, 2, 10)
 	table.Addheaders("shard allocation setting", "value")
 
-	table.Entries = [][]any{
-		{"Index", index},
-		{"Current state", res.CurrentState},
-		{"Can rebalance cluster", res.CanRebalanceCluster.Name},
-		{"Can rebalance to another node", res.CanRebalanceToOtherNode.Name},
-		{"Can remain on current node", res.CanRemainOnCurrentNode.Name},
-	}
-
-	if res.CurrentNode != nil {
-		currentNode := res.CurrentNode
 	roles := make([]string, len(currentNode.Roles))
-
 	for idx, role := range currentNode.Roles {
 		roles[idx] = role.Name
 	}
 
-		table.Entries = append(table.Entries, [][]any{
+	table.Entries = [][]any{
+		{"Index", index},
+		{"Current state", res.CurrentState},
 		{"Current node", currentNode.Name},
 		{"Current k8s node", currentNode.Attributes["k8s_node_name"]},
 		{"Current node address", currentNode.TransportAddress},
 		{"Current node id", currentNode.Id},
 		{"Current node weight", currentNode.WeightRanking},
 		{"Current node roles", roles},
-		}...)
-	} else {
-		table.AddRow("Current node", "not currently assigned to any node")
+		{"Can rebalance cluster", res.CanRebalanceCluster.Name},
+		{"Can rebalance to another node", res.CanRebalanceToOtherNode.Name},
+		{"Can remain on current node", res.CanRemainOnCurrentNode.Name},
 	}
 
 	if res.CurrentState == "unassigned" {

pkg/printer/bytes.go

@@ -22,16 +22,10 @@ type ByteSize struct {
 	size uint64
 }
 
+func Bytes(size int64) ByteSize {
+	return ByteSize{size: uint64(size)}
+}
+
 func (b *ByteSize) String() string {
 	return humanize.Bytes(b.size)
 }
-
-func Bytes(size int64) *ByteSize {
-	return &ByteSize{size: uint64(size)}
-}
-
-func ByteString(size int64) string {
-	b := ByteSize{size: uint64(size)}
-
-	return b.String()
-}

pkg/printer/cast.go

@@ -38,18 +38,12 @@ func any2string(in any) string {
 		return strconv.Itoa(val)
 	case float64:
 		return fmt.Sprintf("%.2f", val)
-	case float32:
-		return fmt.Sprintf("%.2f", val)
 	case []string:
 		return strings.Join(val, ",")
 	case ByteSize:
 		return val.String()
-	case *ByteSize:
-		return val.String()
 	case time.Time:
 		return val.Format("2006-01-02 15:04:05")
-	case time.Duration:
-		return val.String()
 	case []byte:
 		return string(val)
 	case nil:

pkg/printer/table.go

@@ -206,22 +206,6 @@ func (table *Table) AddRow(fields ...any) {
 	table.Entries = append(table.Entries, fields)
 }
 
-func (table *Table) AddRowLate(fields ...any) {
-	table.AddRow(fields)
-
-	if !table.processed {
-		return
-	}
-
-	row := make([]string, len(fields))
-
-	for idx, field := range fields {
-		row[idx] = any2string(field)
-	}
-
-	table.rows = append(table.rows, row)
-}
-
 // needed for json and yaml output
 func (table *Table) toMap() []map[string]any {
 	raw := make([]map[string]any, len(table.Entries))