scip/pcp
1
0
Fork 0
mirror of https://codeberg.org/scip/pcp.git synced 2025-12-17 20:00:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

fixed memory leak during decrypt, reported in #10

Browse Source
This commit is contained in:
git@daemon.de
2015-10-12 12:17:51 +02:00
parent 61d3cbae83
commit 3a8d8c010f
3 changed files with 32 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libpcp/mgmt.c
View File

@@ -788,6 +788,7 @@ pcp_key_t *pcp_import_secret_native(PCPCTX *ptx, Buffer *cipher, char *passphras
}
/* decrypt the blob */
clear = ucmalloc(cipherlen - LMAC);
if(pcp_sodium_verify_mac(&clear, buffer_get_remainder(cipher),
cipherlen, nonce, symkey) != 0) {
@@ -796,7 +797,7 @@ pcp_key_t *pcp_import_secret_native(PCPCTX *ptx, Buffer *cipher, char *passphras
}
/* prepare the extraction buffer */
buffer_add(blob, clear, cipherlen - PCP_CRYPTO_ADD);
buffer_add(blob, clear, cipherlen - LMAC);
/* extract the raw data into the structure */
buffer_get_chunk(blob, sk->mastersecret, LEDSEC);
@@ -837,7 +838,7 @@ pcp_key_t *pcp_import_secret_native(PCPCTX *ptx, Buffer *cipher, char *passphras
sk->type = PCP_KEY_TYPE_SECRET;
/* ready */
ucfree(clear, cipherlen - PCP_CRYPTO_ADD);
ucfree(clear, cipherlen - LMAC);
ucfree(nonce, LNONCE);
buffer_free(blob);
sfree(symkey);
@@ -846,7 +847,7 @@ pcp_key_t *pcp_import_secret_native(PCPCTX *ptx, Buffer *cipher, char *passphras
return sk;
impserr2:
ucfree(clear, cipherlen - PCP_CRYPTO_ADD);
ucfree(clear, cipherlen - LMAC);
impserr1:
ucfree(nonce, LNONCE);