using enum modeflags, use my own usage template, generated from manpage so I don't have to maintain it twice, it's also nicer

cfg/config_test.go

@@ -26,46 +26,26 @@ import (
 func TestPrepareModeFlags(t *testing.T) {
 	var tests = []struct {
 		flag   Modeflag
-		mode   string // input, if any
-		expect string // output
-		want   bool
+		expect int // output (constant enum)
 	}{
 		// short commandline flags like -M
-		{Modeflag{X: true}, "", "extended", false},
-		{Modeflag{S: true}, "", "shell", false},
-		{Modeflag{O: true}, "", "orgtbl", false},
-		{Modeflag{Y: true}, "", "yaml", false},
-		{Modeflag{M: true}, "", "markdown", false},
-		{Modeflag{}, "", "ascii", false},
-
-		// long flags like -o yaml
-		{Modeflag{}, "extended", "extended", false},
-		{Modeflag{}, "shell", "shell", false},
-		{Modeflag{}, "orgtbl", "orgtbl", false},
-		{Modeflag{}, "yaml", "yaml", false},
-		{Modeflag{}, "markdown", "markdown", false},
-
-		// failing
-		{Modeflag{}, "blah", "", true},
+		{Modeflag{X: true}, Extended},
+		{Modeflag{S: true}, Shell},
+		{Modeflag{O: true}, Orgtbl},
+		{Modeflag{Y: true}, Yaml},
+		{Modeflag{M: true}, Markdown},
+		{Modeflag{}, Ascii},
 	}
 
+	// FIXME: use a map for easier printing
 	for _, tt := range tests {
-		testname := fmt.Sprintf("PrepareModeFlags-flags-mode-%s-expect-%s-want-%t",
-			tt.mode, tt.expect, tt.want)
+		testname := fmt.Sprintf("PrepareModeFlags-expect-%d", tt.expect)
 		t.Run(testname, func(t *testing.T) {
-			c := Config{OutputMode: tt.mode}
+			c := Config{}
 
-			// check either flag or pre filled mode, whatever is defined in tt
-			err := c.PrepareModeFlags(tt.flag, tt.mode)
-			if err != nil {
-				if !tt.want {
-					// expect to fail
-					t.Fatalf("PrepareModeFlags returned unexpected error: %s", err)
-				}
-			} else {
-				if c.OutputMode != tt.expect {
-					t.Errorf("got: %s, expect: %s", c.OutputMode, tt.expect)
-				}
+			c.PrepareModeFlags(tt.flag)
+			if c.OutputMode != tt.expect {
+				t.Errorf("got: %d, expect: %d", c.OutputMode, tt.expect)
 			}
 		})
 	}